search

rpmfusion-infra / fedy

Fedy makes it easy to install third-party software in Fedora.
GNU General Public License v3.0
177 stars 20 forks source link

Updated dino repo link to get correct repo #14

Closed ghost closed 4 years ago

kwizart commented 4 years ago

Does the $VERSION_ID will be resolved by fedy at install time or is it possible to use the $releasever variable in the repo definition so it will be adapted across Fedora version upgrade ?

ghost commented 4 years ago

I changed it, maybe better this way.

ghost commented 4 years ago

Not really, he ask for it everytime to push the install button from dino.

kwizart commented 4 years ago

So I guess you still miss-understand why your patch is wrong ?

ghost commented 4 years ago

Yes sorry

Am 13. Dezember 2019 13:47:51 MEZ schrieb "Nicolas Chauvet (kwizart)" notifications@github.com:

So I guess you still miss-understand why your patch is wrong ?

-- You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub: https://github.com/rpmfusion-infra/fedy/pull/14#issuecomment-565429568

-- Diese Nachricht wurde von meinem Android-Gerät mit K-9 Mail gesendet.

kwizart commented 4 years ago

$releasever is a special variable used in a repo url that will be evaluated to the appropriate fedora version whenever one decide to upgrade fedora.

There is no need to hit install again to have every single repository updated to the appropriate version. This will save errors when a more appropriate package is available for a newer fedora release.

kwizart commented 4 years ago

Any update with the appropriate fix ?

ghost commented 4 years ago

I get it now. I will work on a fix.

kwizart commented 4 years ago

It looks like dino is in fedora. Fixed as appropriate in fedy 5.0.2 Thx for the report.

BTW, looking at using $releasever doesn't seem possible with dnf config-manager, we would need another hack (like using the current version and then patching the file to use releasever instead of a hardcoded version...).