rpmfusion-infra / fedy

Fedy makes it easy to install third-party software in Fedora.
GNU General Public License v3.0
177 stars 20 forks source link

Icon / Symbol for software without gui #26

Open MalteKiefer opened 4 years ago

MalteKiefer commented 4 years ago

Maybe there should be an icon that lets the user not, that there is no GUI for this software. Like Neomutt.

MalteKiefer commented 4 years ago

Or a new category. Terminal Apps

kwizart commented 4 years ago

We can have both an icon and a new category, but a new category would would be relevant if we have several components already...

MalteKiefer commented 4 years ago

for the cat:

and we can split syncthing into gtk and terminal version

MalteKiefer commented 4 years ago

When you merged all PRs, I will create the new category. Maybe we call it "Terminal Apps". What do you think @kwizart?

thestonewell commented 4 years ago

It could be a new category. In parallel using (or in the case of non-UI installs) not using an icon can help.

BTW, am working on adding icons for all plugins (where it makes sense). But having a hard time keeping up with all the new plugins :)

Should I commit them as is so you can see how icons are handled and add them with any new plugin by default?

MalteKiefer commented 4 years ago

do you create the Icons by yourself or from any Project? Or the Software original Icons?

thestonewell commented 4 years ago

I am using the original icons (also due to copyright), but am making sure to convert them to a 48x48 png

fedy-screenshot-0
MalteKiefer commented 4 years ago

that ist great. we should add to Code of Conduct or how er war to call IT (Look #28) a Part, that every PR should have a icon included

MalteKiefer commented 4 years ago

I am using the original icons (also due to copyright), but am making sure to convert them to a 48x48 png

fedy-screenshot-0

There ist an update for fedy. You do not use the latest version. :smile:

thestonewell commented 4 years ago

I do... but I took the screenshot earlier... duly following the latest master ;)

kwizart commented 4 years ago

I am using the original icons (also due to copyright), but am making sure to convert them to a 48x48 png

I think it should be better handled by scaling the icon as appropriate. Because we will trade one problem with another when people will have monitors with High DPI.

So If SVG is available, best is to use it. And We will have to find the in the display code a way to have the icons displayed correctly (I know brave and google-cloud-sdk aren't correct in the current fedy)...

thestonewell commented 4 years ago

I have tried the svg approach (and agree these would be best). Given existing code doesn't properly resize them to 48x48 though it is not easy to use them. Nor do all svgs come with a square viewport. Thus, I reverted to just using png and having full control. We could try and fix the code too but it wouldn't solve the square viewport source issue with SVGs

kwizart commented 4 years ago

@thestonewell Having 48x48 icons is better than no icons, if you can provide the missing ones in a PR it would be welcomed. I've tried to dive into the gjs code to see if svg can be scaled, and it looks like more difficult than I expected. (not a JS dev at least).