rpminspect: execvpe: No such file or directory when diffstat is not installed

[davide125]

On CentOS Stream 8 and rpminspect-1.10-1.el8.x86_64 I get

Details:
rpminspect version 1.9
zlib version 1.2.11
libmagic version 533
libclamav version 0.103.7
librpm version 4.14.3
libxml version 20907
json-c version 0.13.1
libcurl version 7.61.1 (OpenSSL/1.1.1k zlib/1.2.11 brotli/1.0.6 libidn2/2.2.0 libpsl/0.20.2 (+libidn2/2.2.0) libssh/0.9.6/openssl/zlib nghttp2/1.33.0)
libarchive version 3.3.3 (zlib/1.2.11 liblzma/5.2.4 bz2lib/1.0.6 liblz4/1.8.3 libzstd/1.4.4)
libyaml version 0.1.7
OpenSSL version 1.1.1k  FIPS 25 Mar 2021
xmlrpc-c version 1.51.0
msgunfmt (GNU gettext-tools) 0.19.8.1
rpminspect: execvpe: No such file or directory
annocheck version 10.94.
abidiff version 2.2.0
kmidiff version 2.2.0

in the initial output when using rpminspect-centos if diffstat is not installed. After installing it, the output is fine:

Details:
rpminspect version 1.9
zlib version 1.2.11
libmagic version 533
libclamav version 0.103.7
librpm version 4.14.3
libxml version 20907
json-c version 0.13.1
libcurl version 7.61.1 (OpenSSL/1.1.1k zlib/1.2.11 brotli/1.0.6 libidn2/2.2.0 libpsl/0.20.2 (+libidn2/2.2.0) libssh/0.9.6/openssl/zlib nghttp2/1.33.0)
libarchive version 3.3.3 (zlib/1.2.11 liblzma/5.2.4 bz2lib/1.0.6 liblz4/1.8.3 libzstd/1.4.4)
libyaml version 0.1.7
OpenSSL version 1.1.1k  FIPS 25 Mar 2021
xmlrpc-c version 1.51.0
msgunfmt (GNU gettext-tools) 0.19.8.1
diffstat version 1.61
annocheck version 10.94.
abidiff version 2.2.0
kmidiff version 2.2.0
...

When testing whether a binary is available, rpminspect should print the name of what's actually missing instead of a generic error. And on el8 the rpminspect package should probably Recommend: diffstat.

[davide125]

Ugh sorry, wrong repo, will refile this under rpminspect proper.

[davide125]

Moved to https://github.com/rpminspect/rpminspect/issues/1074, apologies for the noise.