search

rpng / open_vins

An open source platform for visual-inertial navigation research.
https://docs.openvins.com
GNU General Public License v3.0
2.07k stars 620 forks source link

Failed to override value of launch file using yaml, monocular does not work #269

Closed hoangvietdo closed 1 year ago

hoangvietdo commented 1 year ago

Hi, thank you for sharing your work.

I git clone, built, and ran the project for a custom stereo camera dataset and it worked well. However when I tried to change the YAML file to the monocular camera (i.e., use_stereo: false, max_cameras: 1), the simulation still showed up as 2 cameras.

To run the mono simulation, I directly modify the subscriber.launch, even though it runs correctly in this case but the algorithm is stuck at the initial process and no pose estimation is performed.

goldbattle commented 1 year ago

The launch file always has priority. Either don't override in the launch so it uses the one in the yaml, or edit in the launch file. Should be a print out in console if something gets overwritten.

On Sat, Aug 20, 2022, 9:14 AM Viet @.***> wrote:

Hi, thank you for sharing your work.

I git clone, built, and ran the project for a custom stereo camera dataset and it worked well. However when I tried to change the YAML file to the monocular camera (i.e., use_stereo: false, max_cameras: 1), the simulation still showed up as 2 cameras.

To run the mono simulation, I directly modify the subscriber.launch, even though it runs correctly in this case but the algorithm is stuck at the initial process and no pose estimation is performed.

— Reply to this email directly, view it on GitHub https://github.com/rpng/open_vins/issues/269, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAQ6TYUMCSXIVF3YLCVFJZTV2DK3ZANCNFSM57DG4GGQ . You are receiving this because you are subscribed to this thread.Message ID: @.***>

hoangvietdo commented 1 year ago

@goldbattle Thanks for replying. In the first place, I did not touch the launch at all, I only tried to modify the yaml, but the simulation has no response on that. Probably I should directly modify the launch file in the future. Can you comment on the monocular simulation? It does not work for me.

goldbattle commented 1 year ago

You need to launch the simulation.launch file if you want to run simulation. Everything works as expected on my machine, feel free to reopen if you still have an issue.