search

rpocklin / ui-router-tabs

Idiot-proof tab panes with route support using Angular.js + Bootstrap 3 + UI Router
Other
244 stars 57 forks source link

Add CommonJS package manager support (closes #43) #44

Closed alexilyaev closed 9 years ago

rpocklin commented 9 years ago

I'm hesitant to leave the build in a broken state - any way you can get this to work? Also will this break anything for non-webpack scenarios?

alexilyaev commented 9 years ago

I've fixed the broken build, was missing global variables module and exports in .jshintrc. But now it says something about the Coverage decreased, I'm not sure how to cover that, since it's not inside the module.

Environments that don't use CommonJS will not enter the if with the module.exports, and for those who do support it, it's only a convenience, people can still use the old way.

alexilyaev commented 9 years ago

@rpocklin Can we bump a release for this one?

rpocklin commented 9 years ago

Done! v1.6.0 - thanks for bumping me.

alexilyaev commented 9 years ago

Did you npm publish? How does that work anyway? I mean how does a release tag get on the npm repository?

rpocklin commented 9 years ago

I wish it was automatic :P it's published now.