search

rpocklin / ui-router-tabs

Idiot-proof tab panes with route support using Angular.js + Bootstrap 3 + UI Router
Other
244 stars 57 forks source link

impr: support for angular-bootstrap 0.14.x #47

Closed QuentinFchx closed 8 years ago

QuentinFchx commented 8 years ago

Closes #46

QuentinFchx commented 8 years ago

Should I also fix the update_tabs call (https://github.com/rpocklin/ui-router-tabs/blob/master/src/ui-router-tabs.js#L93) ?

rpocklin commented 8 years ago

Thanks I was just making these changes now but i'll accept your PR since you went to the trouble :)

I'll update those (old) comments and do a version release. Thanks for contributing.

QuentinFchx commented 8 years ago

Thank you :)

On Wed, Oct 14, 2015 at 10:47 PM, Robert Pocklington < notifications@github.com> wrote:

Thanks I was just making these changes now but i'll accept your PR since you went to the trouble :)

I'll update those (old) comments and do a version release. Thanks for contributing.

— Reply to this email directly or view it on GitHub https://github.com/rpocklin/ui-router-tabs/pull/47#issuecomment-148193895 .