search

rpocklin / ui-router-tabs

Idiot-proof tab panes with route support using Angular.js + Bootstrap 3 + UI Router
Other
244 stars 57 forks source link

Added 'bower install' as npm post-install script. #56

Closed amahfouz closed 8 years ago

amahfouz commented 8 years ago

Add an optional configuration parameter "tab-classes" to allow configuring the tabs with arbitrary classes, such as "btn-sm", etc.

rpocklin commented 8 years ago

What's wrong with just passing class instead of tab-classes?

rpocklin commented 8 years ago

If you can re-work this i'll accept it.

amahfouz commented 8 years ago

Thanks. Will do. I am currently trying to get a pull request into the angular-bootstrap so that my change here makes it all the way through.

On Mon, Feb 22, 2016 at 3:55 PM, Robert Pocklington < notifications@github.com> wrote:

If you can re-work this i'll accept it.

— Reply to this email directly or view it on GitHub https://github.com/rpocklin/ui-router-tabs/pull/56#issuecomment-187443096 .

rpocklin commented 8 years ago

Made similar changes to master branch, feel free to give feedback on it.