search

rpocklin / ui-router-tabs

Idiot-proof tab panes with route support using Angular.js + Bootstrap 3 + UI Router
Other
244 stars 57 forks source link

Adapt to new API in UI Bootstrap 1.2 #65

Closed wesleycho closed 8 years ago

wesleycho commented 8 years ago

This should address #58.

wesleycho commented 8 years ago

Should note, the tests in this PR passes when #66 is merged.

titobf commented 8 years ago

Cool. I just upgraded to ui-bootstrap 1.2.4 and this seems to fix it perfectly. Thanks!

rpocklin commented 8 years ago

I'll release this with a major version bump since it changes semantics.

Does the example work now or is it broken?

wesleycho commented 8 years ago

It works - I recommend verifying it locally (one way is to do git checkout -b pr65 && curl https://patch-diff.githubusercontent.com/raw/rpocklin/ui-router-tabs/pull/65.patch | git am -3) to be safe

wesleycho commented 8 years ago

Any ETA on this? This is an important change for my company - obviously respond whenever convenient, but would be nice to have advance notice on when I can integrate this to work (a UI Bootstrap bug causes unit tests to run linearly slowly prior to 1.2.2).

rpocklin commented 8 years ago

After Easter. You can always point to your forked branch in the meantime.

wesleycho commented 8 years ago

Thanks!

No worries, we're not in an immediate rush to upgrade since 1.2 comes with other major API changes in UI Bootstrap.

rpocklin commented 8 years ago

Hi, i've adapted some of what you did and bumped the necessary versions of libraries - can you test out using the master branch, if it's all good I will release it.

wesleycho commented 8 years ago

Sure, will test it out when I get in the office

wesleycho commented 8 years ago

master breaks on 1.2 and higher - the template is incorrect for that situation.

rpocklin commented 8 years ago

So one breaking change I made is the default template was flipped, can you specify the correct template-url and retry?

bobbytes commented 8 years ago

How's the status?

rpocklin commented 8 years ago

If I don't hear back from @wesleycho in the next few days i'll release a new version.

rpocklin commented 8 years ago

Released v2.0.0, feel free to raise any issues against it.