search

rpocklin / ui-router-tabs

Idiot-proof tab panes with route support using Angular.js + Bootstrap 3 + UI Router
Other
244 stars 57 forks source link

update to latest version on npm as well - active tab not set properly when url loaded #73

Closed imaksp closed 8 years ago

imaksp commented 8 years ago

npm version still using very old version, please update. https://www.npmjs.com/package/angular-ui-router-tabs

imaksp commented 8 years ago

@rpocklin Active tab not still not selected with UI Bootstrap 1.3.2 - active (index) attribute has been moved to <uib-tabset>

Also tab child controllers are loaded two times on page load can anyone suggest why it is loaded twice?

rpocklin commented 8 years ago

If you read the current PRs and issues we are about to release a new version to support UI Bootstrap 1.x.x so please hold off on those related issues until it has been released.

imaksp commented 8 years ago

ok btw that two times ctrl load issue is not occurring if I use custom template & specify <ui-view></ui-view> in parent. Currently I have fixed active tab issue in my local copy by moving active attrib. to <uib-tabset>. Also please release latest version to npm after you add support for latest UI Bootstrap(1.3.x) so I can switch again to npm version. Thanks.

rpocklin commented 8 years ago

No worries, those issues have been addressed in the new version, should be released this week.

rpocklin commented 8 years ago

Released v2.0.0, feel free to raise any issues against it.