Fixing `is-active` testing for sibling, equal and ancestor routes

rpocklin / ui-router-tabs

Idiot-proof tab panes with route support using Angular.js + Bootstrap 3 + UI Router

Other

244 stars 57 forks source link

Fixing `is-active` testing for sibling, equal and ancestor routes #92

Open rpocklin opened 7 years ago

rpocklin commented 7 years ago

This should resolve issues around #91 and #71 collectively.

rpocklin commented 7 years ago

@fa137 @ollycross can you review this for me? I will investigate why these builds are failing.

coveralls commented 7 years ago

Coverage decreased (-3.2%) to 94.444% when pulling 2f486cc98f1f55f3670fc054c3126f0ecb97185b on fix-is-active into db413f40779fe93895a1c611c121f3e1de92cfbe on master.