rpocklin / ui-router-tabs

Idiot-proof tab panes with route support using Angular.js + Bootstrap 3 + UI Router
Other
244 stars 57 forks source link

Default template active attribute seems wrong #93

Open mhirsch opened 7 years ago

mhirsch commented 7 years ago

I could be missing something, but in the inline template https://github.com/rpocklin/ui-router-tabs/blob/db413f40779fe93895a1c611c121f3e1de92cfbe/src/ui-router-tabs.js#L120 the active attribute is set active="tabs.active", but in the directive tabs is a reference to whatever is passed in to the tabs attribute, which https://github.com/rpocklin/ui-router-tabs/blob/master/README.md says ought to be an array (i.e. won't have an active property).