search

rpoleski / MulensModel

Microlensing Modelling package
https://rpoleski.github.io/MulensModel/
Other
56 stars 15 forks source link

Fix interp2d import, issue #74 #113

Closed rapoliveira closed 9 months ago

rapoliveira commented 10 months ago

The scipy function interp2d (to be deprecated soon, issue #74) was replaced by RegularGridInterpolator in two codes:

I tested the changes only in the second code, which lead to differences smaller than 1e-10 in the interpolated values.

rapoliveira commented 10 months ago

@rpoleski the tests failed in test_Lee09_and_WittMao94() function of test_MagnificationCurve.py, but passed in my local repository. Since the failure is not related to my changes, should I try to commit once more?

codecov-commenter commented 10 months ago

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (2e55c55) 83.61% compared to head (8e879bb) 83.53%. Report is 4 commits behind head on master.

Files Patch % Lines
source/MulensModel/pointlens.py 66.66% 3 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #113 +/- ## ========================================== - Coverage 83.61% 83.53% -0.08% ========================================== Files 52 52 Lines 8271 8286 +15 ========================================== + Hits 6916 6922 +6 - Misses 1355 1364 +9 ``` | [Flag](https://app.codecov.io/gh/rpoleski/MulensModel/pull/113/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Radek+Poleski) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/rpoleski/MulensModel/pull/113/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Radek+Poleski) | `83.53% <66.66%> (-0.08%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Radek+Poleski#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.