rpoleski / MulensModel

Microlensing Modelling package
https://rpoleski.github.io/MulensModel/
Other
57 stars 15 forks source link

Feature Request: Add xallarap effect #48

Closed zhechenghu closed 1 year ago

zhechenghu commented 2 years ago

Hi Radek/Jennifer,

Thank you for providing such a fantastic python package of microlensing modeling! I found it super helpful while learning microlensing.

I wonder whether it is possible to add the xallarap effect, which is an effect similar to microlensing parallax. A paper describes this effect clearly: Miyazaki et al..

It would be appreciated so much if you could add this feature!

Cheers

rpoleski commented 2 years ago

Hi,

This is on our radar for a long time. We take great care when adding new features: there is always brainstorming on how to name functions, classes, parameters etc. This also happens slowly for xallarap. Though I cannot promise when it will be done. If you want to implement it yourself, then you have to modify Trajectory class.

I'm glad MM was useful for you.

rpoleski commented 1 year ago

I'm currently working on xallarap. @zhechenghu If you're still interested in this feature, please contact me via email.

rpoleski commented 1 year ago

Xallarap is already part of the master branch. Closing.