Closed jenniferyee closed 1 year ago
Note: I haven't updated the version number yet.
Let's follow scout rule - leave the code better than you found it. In this case the unit tests are missing. Also it would be good to add notes in class docstrings.
We still need unit tests for model.py
(lines 118 and 122), event.py
, and mulensdata.py
.
One more aspect - how we want to note these in documentation? One approach is to add a sentence about it in __init__()
docstrings for each class. Other possibilities?
Extended example 24 to cover the new repr for coordinates, limb-darkening, and errorbar rescaling. Updated the formatting in MulensData.repr so the numbers line up. Looks ready to merge to me.
@jenniferyee - 2 new notes and 1 one old issue.
test_Event.test_repr_full() / Event._repr_()
event = mm.Event(model=model, datasets=[dataset, dataset])
This produces weird behavior because Event.data_ref is sometimes stored as a MulensData instance. So, both datasets get flagged as being "data_ref".
I am going to change the test to use two different datasets. But I am leaving this comment here as a record of potentially weird behavior when using duplicate datasets within the same Event.
- Do you want full path to the ephemerides file to be printed? We don't print full path to the data file.
We decided to not change it and print the path as provided.
The last commit solves the issue with duplicated datasets (see last comment by @jenniferyee). Note that I removed one test that used duplicated datasets and changed a few other ones.
I don't see anything else to do here. This branch can be merged (don't forget to run sphinx and release new version).
… to give info I usually want + an example showing how they work.