search

rpoleski / MulensModel

Microlensing Modelling package
https://rpoleski.github.io/MulensModel/
Other
57 stars 15 forks source link

VBBL update #82

Closed rpoleski closed 1 year ago

rpoleski commented 1 year ago

We should update VBBL to version 3.5. It's not a simple copy-paste because we have shear and convergence coded in the same file. Our version shoud be compared with oldest VBBL on github, i.e., v2.0.1. Current version

rpoleski commented 1 year ago

I've checked that the VBBL version we're using differs from 2.0.1 by 3 functions implemented by @alpv95: VBBinaryLensing::BinaryMag0_shear(double a1, double q1, double y1v, double y2v, double K1, double G1, double Gi, _sols **Images) VBBinaryLensing::BinaryMag0_shear(double a1, double q1, double y1v, double y2v, double K1, double G1, double Gi) VBBinaryLensing::NewImages_shear(complex yi, complex *coefs, _theta *theta) Hence, updating VBBL in MM should be easy.

rpoleski commented 1 year ago

The above listed functions also require:

#define _Jacobians1_shear
#define _LL_shear
rpoleski commented 1 year ago

VBBL was updated ~6 weeks ago.