Should we remove any API for action creators?

[rpominov]

Currently we have following API:

// Define:
let myActionCreator = (fluce) => {
  return (some, args) => {
    fluce.dispatch('actionName', payload);
  }
};

// Register:
const fluce = createFluce();
fluce.addActionCreator('actionCreatorName', myActionCreator);

// Call:
fluce.actions.actionCreatorName(some, args);

Wouldn't it be better if we simply didn't have any API:

// Define:
function myActionCreator(fluce, some, args) {
  fluce.dispatch('actionName', payload);
}

// Call:
myActionCreator(fluce, some, args);

The only disadvantage of removing the API is that with API programmer can stash some action related state in the closure, for instance:

let refreshFoo = (fluce) => {
  let latestRequest;
  return () => {
    fluce.dispatch('refreshFooStart');
    if (latestRequest !== undefined) {
      latestRequest.cancel();
    }
    latestRequest = myApi.getLatestFoo((foo) => {
      fluce.dispatch('refreshFooSuccess', foo);
      latestRequest = undefined;
    })
  }
};

This is a rare use case, and programmer will have following options:

• Stash that state on the fluce instance e.g., fluce.__refreshFooLatestRequest = ...
• Save that state in a store e.g., fluce.dispatch('refreshFooStart', cancelableRequest)
• If she don't care about multiple Fluce instances, simply save that state "near" action creator declaration:

// foo-actions.js

let latestRefreshRequest;
export refreshFoo(fluce) { /*...*/ }

---

Related: #6