Closed melhemr closed 3 years ago
Awesome work, @melhemr ! The code looks good to me. Though I'm wondering what additional functionality this accomplishes. Is it the ability to apply the model to new, unseen sites?
If @AbdulkadirA is on board with this, I'm happy to merge right away.
@rpomponio I am on board with this. And yes, it enables to predict the standardized mean from external data.
Awesome, I just merged and I am going to update the version number.
Thank you so much Ray! I'm glad I could contribute to the project!
From: Raymond Pomponio @.> Sent: Tuesday, July 20, 2021 12:20 PM To: rpomponio/neuroHarmonize @.> Cc: Melhem, Randa Randa.Melhem@Pennmedicine.upenn.edu; Mention @.***> Subject: [External] Re: [rpomponio/neuroHarmonize] Update scripts to account for new SITES (#9)
Awesome, I just merged and I am going to update the version number.
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/rpomponio/neuroHarmonize/pull/9#issuecomment-883523627, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ATRQL4IPK5UIPFKOLDGSNV3TYWO5HANCNFSM44W3VQ6A.
@AbdulkadirA and @rpomponio can you review the changes we've made and merge if you think this is ready