rposborne / wkhtmltopdf-heroku

wkhtmltopdf binary for heroku / amd64
MIT License
225 stars 92 forks source link

upgrade to 0.12.5 #39

Closed pallymore closed 6 years ago

pallymore commented 6 years ago

@rposborne could you take a look at this?

wkthmltopdf just released 0.12.5 recently - it seems now they are providing separate binaries for Ubuntu 14, 16, and 18 - for now I have only included the 16 version.

rposborne commented 6 years ago

@pallymore this looks good to me. Should we do a major bump and switch to 18 binaries?

pallymore commented 6 years ago

I'd say let's keep using 16 for now as Heroku-18 stack is still in "public beta" status.

image

Maybe later we could offer 18 in a separate branch if the 16 binary cannot be used in Heroku-18.