search

rposborne / wkhtmltopdf-heroku

wkhtmltopdf binary for heroku / amd64
MIT License
223 stars 93 forks source link

Experimental support for Stack-22 #56

Closed spickermann closed 2 weeks ago

spickermann commented 1 year ago

Hey there,

I noticed that 2.12.6.1.pre.jammy was released sometime ago. I wonder how you feel about releasing a non-pre version of it?

Did you get some feedback about this version? Are there any known issues? Or would you consider it production ready, and can you recommend using it?

pallymore commented 1 year ago

Hi 👋🏻

Thanks - I haven't seen any feedback / comments regarding that version - however at the same time I haven't had a chance to test it thoroughly myself. At this moment I'm not sure how to release this as it's not backward compatible with Heroku 20 or 18 - it's probably going to be a major version bump.

I think it's fine to use this in production as long as you have sufficiently tested your use cases - results from wkhtmltopdf are often heavily depend on how the pages are implemented.

spickermann commented 1 year ago

Hey, I just wanted to let you know that we have been using 2.12.6.1.pre.jammy for the last 10 days in production on stack22 on Heroku. No issues at all. Works fine and as expected. Thank you!

MicahBrown commented 1 year ago

We've also been using 2.12.6.1.pre.jammy in production for a few days and haven't noticed any issues yet.

navidemad commented 1 year ago

We have been using it for few months, no issue also

pallymore commented 1 year ago

Hi all - thank you for the responses!

I've pushed a new major version for jammy support:

https://rubygems.org/gems/wkhtmltopdf-heroku/versions/3.0.0.pre.rc0

Changelog: https://github.com/rposborne/wkhtmltopdf-heroku/blob/main-v3/CHANGELOG.md#300prerc0---2023-02-07

It's exactly the same as 2.12.6.1.pre.jammy - just a major version bump. I will make a prod release once I get a chance to test it myself. Thanks again

jeffbax commented 1 year ago

Do we expect that this will remain compatible with 18/20 or is this 22 only?

pallymore commented 1 year ago

I haven't tested them in 18/20 but my impression is it only works in heroku-22 due to the underlying dependency changes.

jeffbax commented 1 year ago

@pallymore thanks for the heads up, appreciate it!

jeffbax commented 1 year ago

Gave this a shot in a review app on Heroku-22 and seemed to be working fine and will be using it to upgrade our pipeline

pallymore commented 12 months ago

thanks!

jslag commented 6 months ago

from a quick test on our app, 2.12.6.1.pre.jammy is not getting styling or images that were working previously.

actually, I think that was a testing error and not a problem with this gem. Whoops!

spickermann commented 4 weeks ago

Heroku released the new heroku-24 stack recently. So far, I haven't noticed any issues running gem 'wkhtmltopdf-heroku', '>= 3.0.0.pre.rc0' with the new stack. Works as expected and as it did previously with the heroku-22 stack.

This 3.0.0.pre.rc0 version has been tested quite a while already. Why not just release the 3.0.0 version officially?

pallymore commented 2 weeks ago

Hi - sorry I haven't been checking Github for a while. Sounds like everyone is happy with 3.0.0.pre.rc0 😁 I can publish 3.0.0 later today

pallymore commented 2 weeks ago

Hi all - 3.0.0 is out. thanks!