search

rpremraj / mailR

A utility to send emails from the R programming environment
http://rpremraj.github.io/mailR/
190 stars 57 forks source link

Added overriding of default timeouts #30

Closed CharlesCara closed 9 years ago

CharlesCara commented 9 years ago

socketConnectionTimeout and socketTimeout added as allowed values of smtp

CharlesCara commented 9 years ago

socketConnectionTimeout and socketTimeout added as allowed values of smtp

CharlesCara commented 9 years ago

Hi Raj.

I think mailR is great, but I was getting timeouts on our smtp server. I have added and documented the abilty to override the default timeouts.

rpremraj commented 9 years ago

Thanks for this. I will merge it in shortly...

What error did you receive upon timeout? Could you share it with me?

rpremraj commented 9 years ago

Would you like to take a crack at it and re-send the pull request (preferably to the develop branch)?

I suggest we try something like:

send.mail <- function(from, to, subject = "", body = "", encoding = "iso-8859-1", html = FALSE, inline = FALSE, smtp = list(), authenticate = FALSE, send = TRUE, attach.files = NULL, timeout = 60000, debug = FALSE, ...)
{
...
# your new code
}
CharlesCara commented 9 years ago

Yes I can do that when I am back in the office tomorrow.

Charles

On 2 Jul 2015, at 22:15, Rahul Premraj notifications@github.com wrote:

Would you like to take a crack at it and re-send the pull request (preferably to the develop branch)?

I suggest we try something like:

send.mail <- function(from, to, subject = "", body = "", encoding = "iso-8859-1", html = FALSE, inline = FALSE, smtp = list(), authenticate = FALSE, send = TRUE, attach.files = NULL, timeout = 60000, debug = FALSE, ...) { ...

your new code

} — Reply to this email directly or view it on GitHub https://github.com/rpremraj/mailR/pull/30#issuecomment-118170596.

rpremraj commented 9 years ago

Awaiting new pull request.