Shouldn't -W be included in the case of FACSVerse data in the build up to filter params for flowAI::autoQC?

rprops / Phenoflow_package

R package offering functionality for the advanced analysis of microbial flow cytometry data

GNU General Public License v2.0

9 stars 5 forks source link

Shouldn't -W be included in the case of FACSVerse data in the build up to filter params for flowAI::autoQC? #58

Closed FMKerckhof closed 6 years ago

FMKerckhof commented 6 years ago

See e.g.

https://github.com/rprops/Phenoflow_package/blob/00687dccccd192a0fa40969f205b68b2d2de46f6/R/RandomF_predict.R#L44

rprops commented 6 years ago

Will come down to the same thing in 99% of the cases as you won't feed a -W parameter w/o the -A/-H included. But will adjust in next commit so it can handle that.

FMKerckhof commented 6 years ago

No worries, I'll make a PR, since it is relevant to me

FMKerckhof commented 6 years ago

Fixed in 53a639374d8d780b9d249e62b19b3a425b4bf255