rprouse / GitHubExtension

A visual studio extension for interacting with GitHub.
MIT License
34 stars 10 forks source link

Creating new issues fails #81

Closed rprouse closed 9 years ago

rprouse commented 9 years ago

Creating new issues is failing ocassionally with an authentication error, why? It works sometimes, but I seem to get this consistently occasionally,

---------------------------
Microsoft Visual Studio
---------------------------
GitHub Extension

Failed to save issue.

ApiValidationException:

Validation Failed
---------------------------
OK   
---------------------------
rprouse commented 9 years ago

I entered octokit/octokit.net#612 to see if they have an idea what I am doing wrong.

rprouse commented 9 years ago

If I can get the X-GitHub-Request-Id in the response, @shiftkey will take a look in the backend to try to figure out what is going on. I am completing #69 to log out the information we need for the next time this happens.

rprouse commented 9 years ago

Digging into the exception, it looks like an empty string is an invalid assignee, will try switching to null. Should also check the milestone.

shiftkey commented 9 years ago

it looks like an empty string is an invalid assignee, will try switching to null.

I believe this is the issue - perhaps the backend is handling "" differently to null

sharwell commented 9 years ago

@shiftkey This seems like a good place to propose an update to the API, where "" is treated as not having a user assigned. Do you have a place where users can file proposals like this?

rprouse commented 9 years ago

It was the "" for assignee, it needs to be null. I did some experimenting, milestone also needs to be null, not 0 and it is the same for updating the issue.