search

rptaylor / kapel

APEL accounting for Kubernetes.
GNU General Public License v3.0
3 stars 3 forks source link

Update cronjob.yaml to optionally support 'nodeSelector:' and 'tolerations:' #64

Closed mwestphall closed 2 months ago

rptaylor commented 2 months ago

@mwestphall Nice, thanks!
These configurables are the same as others that are currently under the cronjob section, e.g. .Values.cronjob.priorityClassName. IMO that makes it more specifically scoped and accurately described than a top-level variable (also what if e.g. there are other things running beside just the cron job in some future architecture).

I don't have a strong preference though. Is this something Brian touched on in a previous discussion? I could go the other way if there is a reason for it but we should try to move toward consistency one way or another.

Anyway whatever the name of the value is can you add a line in the README please?

mwestphall commented 2 months ago

@rptaylor I moved the nodeSelector/tolerations under the cronjob object and updated the readme