search

rpuig2001 / CDM

CDM
GNU General Public License v3.0
22 stars 9 forks source link

Master role remains active after disconnect/reconnect #105

Closed kusterjs closed 1 year ago

kusterjs commented 1 year ago

While using the same instance of Euroscope, the master role is not automatically terminated when the connection is closed. This could lead to possible interference when the user later on logs in again (even under a different call sign) as the master role will still be engaged. When disconnecting from the network, the master role should automatically be dropped.

Iwhite67 commented 1 year ago

Hello, for me no, because some time, we have AFV error, i can't reconnect, i need to deco/reco ES for have AFV.

if you need to change people on CDM, is good to make a .cdm slave {airport}

rpuig2001 commented 1 year ago

While using the same instance of Euroscope, the master role is not automatically terminated when the connection is closed. This could lead to possible interference when the user later on logs in again (even under a different call sign) as the master role will still be engaged. When disconnecting from the network, the master role should automatically be dropped.

I agree on that and I will implement it accordingly.

Hello, for me no, because some time, we have AFV error, i can't reconnect, i need to deco/reco ES for have AFV.

if you need to change people on CDM, is good to make a .cdm slave {airport}

If you do that you are aware that you are reconnecting, so, as soon as you connect again you can set ".cdm master ....". Otherwise you may log off for any reason and without taking care, connect again still being a master (Which is a bigger problem that can be easily solved).

rpuig2001 commented 1 year ago

Todo: https://github.com/rpuig2001/CDM/commit/e5cd371c5937ebe4d5acc5169da83aff744ac9f1#commitcomment-109814388