search

rpwoodbu / mosh-chrome

Mosh for Chrome
GNU General Public License v3.0
372 stars 59 forks source link

Support ed25519 host keys #103

Open rpwoodbu opened 9 years ago

rpwoodbu commented 9 years ago

libssh 0.7.0 added support for ed25519 ssh host keys. However, when updating libssh, it was discovered (and reported in Issue #102) that there was a problem verifying such keys. As a workaround, I'm skipping ed25519 host keys (SHA 0f2d3a1).

Some time should be spent to understand the problem and reintroduce support for this host key type. It is unclear if this is a libssh problem, or a problem with how the library is being configured/built. One issue of note is this error in the linker output:

error: ../build/libssh-0.7.1/build/src/libssh.a: multiple definition of 'crypto_sign_ed25519_ref_ge25519_base'

And indeed, that symbol shows twice in libssh.a.

ghost commented 6 years ago

Hey! I think it's a good time to consider that issue since now we have ed25519 in: Debian 8 Jessie oldstable (old), Debian 9 Stretch stable (current), Debian 10 Buster testing (next).

Only Debian 7 Wheezy oldoldstable (EOL) is missing this. It's LTS external support till May. The internal official support is ended last year.

I see few changes in the libssh related to this: version 0.7.1 Fixed SSH_AUTH_PARTIAL auth with auto public key Fixed allocation of ed25519 public keys version 0.7.4 Added id_ed25519 to the default identity list

rpwoodbu commented 6 years ago

Thanks for that update, @signalguest. I've added it to my list. (No promises on when.)