search

rpwoodbu / mosh-chrome

Mosh for Chrome
GNU General Public License v3.0
371 stars 59 forks source link

Can't seem to pass command-line arguments to mosh binary #175

Open patrickxia opened 6 years ago

patrickxia commented 6 years ago

On very high-latency connections like plane connections, I like to run with --predict=experimental, which makes it so that local echo prediction is always enabled (without waiting for 1 RTT per line to make sure that the terminal isn't echoing, for, e.g., password prompts).

Unless I'm missing something, there doesn't seem to be a way to pass this to the mosh binary in this extension. Can we get some sort of support for custom command-line flags?

If I've done my homework properly, it's just plumbing into https://github.com/rpwoodbu/mosh-chrome/blob/63a94642999c6352b008bf186bf09f07e8034838/mosh_nacl/mosh_nacl.cc#L621, right?

rpwoodbu commented 6 years ago

Sorry for the delay; somehow I missed this during the holidays.

Actually, most flags, including --predict, are given to the mosh command, not to mosh-client, which is what's implemented here. It is delivered to mosh-client via the MOSH_PREDICTION_DISPLAY environment variable (see the mosh-client(1) man page).

I'm open to adding a drop-down or some such to the main connection setup window to set this. Pull requests are welcome.