search

rpwoodbu / mosh-chrome

Mosh for Chrome
GNU General Public License v3.0
372 stars 59 forks source link

True color (24-bit) not working #188

Open thallada opened 6 years ago

thallada commented 6 years ago

Thanks for this awesome app. I'm having some trouble getting true color support working.

I signed into the same server using mosh-chrome and the Secure Shell app. I used the same true color support test script mentioned here in both.

Secure Shell: image

mosh-chrome: image

In both terminals, echo $TERM returns xterm-256color.

I noticed that the version of hterm in this repo (1.6.1) is a bit behind the latest version (1.7.8). Maybe upgrading it could resolve this?

rpwoodbu commented 6 years ago

You may be on to something with the version of hterm. Try the "Mosh (dev)" version in the Chrome Web Store, which is newer. I'm going to be pushing hterm-1.80 tonight (in v0.5.5).

ironiridis commented 6 years ago

Edited to update: I had the wrong terminal color sequence here. Here's the correct test result: image

Looks like it could be improved, but it's very passable at this point. Tested on v0.5.5. Close?

jxyzn commented 6 years ago

Mosh (dev) v0.5.5 fails to render 24-bit color for me, appearing the same as shown in the original report above.

bukzor commented 6 years ago

Truecolor is screwing in mosh. It seems to be the binary rather than the app though, as it's also wrong under ssh+mosh localhost.

Normal: screenshot 2018-08-22 at 1 19 14 pm

Mosh: screenshot 2018-08-22 at 1 16 50 pm

rpwoodbu commented 6 years ago

They apparently added support in Mosh 1.3.2 (see mobile-shell/mosh#649), and that's the version being used in the latest dev release, but it doesn't seem to be working.

Edit: I misread the issue. Support was added since 1.3.2, but as of the time of this writing, no official release has been made with that commit.

bukzor commented 6 years ago

1.3.2 is also what I ran in my ssh+mosh --local 127.0.0.1 test, with same wonky result. Here's my truecolor test https://gist.github.com/bukzor/f880fc1e93fc081f079fd6e6aed8b2ea#file-colortest16777216

jxyzn commented 6 years ago

Yeah, there's something else afoot. 24-bit color works in Secure Shell App 0.8.44.1, both via plain ssh and after 'mosh localhost' (with mosh 1.3.2), but does not work connected via Mosh (dev) v0.5.5 -- for me; not sure how @ironiridis got the reduced fidelity results shown in that screenshot.

jxyzn commented 6 years ago

chrome ssh 24-bit test: chrome ssh 24-bit test chrome ssh mosh local 24-bit test: chrome ssh mosh local 24-bit test chrome mosh dev 0.5.5 24-bit test: chrome mosh dev 0.5.5 24-bit test

rpwoodbu commented 6 years ago

Edited my previous statement about mosh 1.3.2. It does not include the true color commit. So this is not expected to work yet.

jxyzn commented 6 years ago

Ah yes, it takes a custom build to enable it (which I have). Wish they'd push it out officially soon.

niutech commented 5 years ago

I wanted to run browsh using Mosh (dev) Chrome app version 1.3.2, but it still does not display glyphs properly:

image

When will the truecolor version be released?

thallada commented 5 years ago

For anyone looking for a solution to this, I was able to get true color mosh working on my chromebook with crouton. Once crouton is set up, enter the chroot, add the mosh-dev ppa, then sudo apt-get install mosh. After that mosh --version should say "mosh 1.3.2". Then you should be able to connect to another server running mosh 1.3.2 and get true color support.

I think the crosh shell uses the Secure Shell terminal app, so it's approximately the same experience but there may be some latency since it's now going through the chroot, not sure.

I think whatever mosh client is bundled with mosh-chrome is too old or doesn't have true color support enabled.

makew0rld commented 4 years ago

Also experiencing this.

Ah yes, it takes a custom build to enable it (which I have). Wish they'd push it out officially soon.

@jxyzn How can I do this?

jxyzn commented 4 years ago

@jxyzn How can I do this?

The easiest method is as @thallada describes. Either add the mosh-dev ppa, or go to the repo and grab the .deb (for me, currently http://ppa.launchpad.net/keithw/mosh-dev/ubuntu/pool/main/m/mosh/mosh_1.3.2+1354-0ppa~ubuntu19.04.1_amd64.deb) and install it.

That build is patched for 24-bit color.

pgraham commented 3 years ago

Is it possible to build this app against the mosh master branch rather than the release? It doesn't look like mosh is going to have another release any time soon, if ever and even the ppa suggested by @thallada hasn't been updated since Feb 2019.

vapier commented 3 years ago

use Secure Shell -- it includes this mosh project now. https://chrome.google.com/webstore/detail/iodihamcpbpeioajjeobimgagajmlibd