rpwoodbu / mosh-chrome

Mosh for Chrome
GNU General Public License v3.0
372 stars 59 forks source link

setting MOSH_ESCAPE_KEY appears to do nothing #83

Closed hdp closed 9 years ago

hdp commented 9 years ago

After setting what I think this the correct hterm pref (moshclient.io.terminal.prefs.set('environment', {TERM: 'xterm-256color', MOSH_ESCAPE_KEY: '~'})), I still have C-^ as the escape key. This environment variable was changed in mosh in May 2013 (https://github.com/keithw/mosh/commit/f960a8bcf56294ca7aafe3c14fc8c8c4c3941535), so I expected it to work in mosh-chrome.

Am I holding it wrong?

keithw commented 9 years ago

That feature is only in Git. It hasn't been documented yet (which we will need to do before we can release a Mosh with it). Happy to take a pull request to keithw/mosh that adds it to the man page. On Mar 29, 2015 7:56 AM, "Hans Dieter Pearcey" notifications@github.com wrote:

After setting what I think this the correct hterm pref (moshclient.io.terminal.prefs.set('environment', {TERM: 'xterm-256color', MOSH_ESCAPE_KEY: '~'})), I still have C-^ as the escape key. This environment variable was changed in mosh in May 2013 ( keithw/mosh@f960a8b https://github.com/keithw/mosh/commit/f960a8bcf56294ca7aafe3c14fc8c8c4c3941535), so I expected it to work in mosh-chrome.

Am I holding it wrong?

— Reply to this email directly or view it on GitHub https://github.com/rpwoodbu/mosh-chrome/issues/83.

rpwoodbu commented 9 years ago

Furthermore, Mosh for Chrome doesn't make use of this "environment" setting in hterm (this is the first I've heard of it). The Native Client environment cleans out the environment, so some effort would have to be taken to reconstruct it.

FYI: There's a pull request outstanding which adds a page for setting these kinds of things. They're all hterm settings at the moment, but once that's in, I may expand it to include settings such as these. Of course, since the upstream mosh hasn't cut a release with this (as @keithw points out), we'll have to wait.

Feel free to ping this bug or open a new one once this is in an upstream mosh release, and we can see about exposing this option.