search

rpwoodbu / mosh-chrome

Mosh for Chrome
GNU General Public License v3.0
372 stars 59 forks source link

Tab keypress lost, causes TypeError in hterm #88

Closed gsf closed 9 years ago

gsf commented 9 years ago

This is on the dev channel of ChromeOS, and it's really an hterm issue, and it's a known issue (https://code.google.com/p/chromium/issues/detail?id=468560), but I thought I'd create an issue here in case anyone else runs into it while using mosh-chrome.

The error is caused by the attempt to assign false to e.shiftKey at line 1199 of hterm.js (line 161 of hterm_keyboard_keymap.js). A workaround for the time being is to simply remove that line.

gsf commented 9 years ago

And from that chromium issue thread it appears that it's fixed in hterm as of this commit: https://chromium-review.googlesource.com/#/c/261315.

gsf commented 9 years ago

Looks from that issue thread like the fix has been rolled into stable secure shell so as soon as mosh-chrome updates that dependency we should be good.

sasnfbi1234 commented 9 years ago

about how long do you think that will take?

rpwoodbu commented 9 years ago

Gadzooks! I just updated myself, and am now hit with this. Looks like I'll be fixing this immediately. Stay tuned.

sasnfbi1234 commented 9 years ago

thanks a million rpwoodbu!

sasnfbi1234 commented 9 years ago

so sorry. how could I update to fix this issue?

rpwoodbu commented 9 years ago

I have just pushed this to the "dev" channel. I will push to the main app shortly. It will update itself.

sasnfbi1234 commented 9 years ago

open source software is so cool! thanks

rpwoodbu commented 9 years ago

For any onlookers: Be sure to close your Mosh windows for a few minutes for Chrome to apply the update.

gsf commented 9 years ago

Thanks for the update, @rpwoodbu!