search

rq / django-rq

A simple app that provides django integration for RQ (Redis Queue)
MIT License
1.82k stars 286 forks source link

LooseVersion is deprecated #530

Open reybog90 opened 2 years ago

reybog90 commented 2 years ago

Hi, I encountered the following warning running our tests with warnings enabled:

...
  File "/buildbot/worker/worker/backend_tests/build/env/lib/python3.7/site-packages/django/template/backends/django.py", line 25, in __init__
    options['libraries'] = self.get_templatetag_libraries(libraries)
  File "/buildbot/worker/worker/backend_tests/build/env/lib/python3.7/site-packages/django/template/backends/django.py", line 43, in get_templatetag_libraries
    libraries = get_installed_libraries()
  File "/buildbot/worker/worker/backend_tests/build/env/lib/python3.7/site-packages/django/template/backends/django.py", line 108, in get_installed_libraries
    for name in get_package_libraries(pkg):
  File "/buildbot/worker/worker/backend_tests/build/env/lib/python3.7/site-packages/django/template/backends/django.py", line 121, in get_package_libraries
    module = import_module(entry[1])
  File "/buildbot/worker/worker/backend_tests/build/env/lib/python3.7/importlib/__init__.py", line 127, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
  File "<frozen importlib._bootstrap>", line 1006, in _gcd_import
  File "<frozen importlib._bootstrap>", line 983, in _find_and_load
  File "<frozen importlib._bootstrap>", line 967, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 677, in _load_unlocked
  File "<frozen importlib._bootstrap_external>", line 728, in exec_module
  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
  File "/buildbot/worker/worker/backend_tests/build/env/lib/python3.7/site-packages/django_rq/templatetags/jquery_path.py", line 8, in <module>
    if LooseVersion(get_version()) >= LooseVersion('1.9'):
  File "/buildbot/worker/worker/backend_tests/build/env/lib/python3.7/site-packages/setuptools/_distutils/version.py", line 57, in __init__
    stacklevel=2,
DeprecationWarning: distutils Version classes are deprecated. Use packaging.version instead.

Package versions:

Django==2.2.24
django-rq==2.4.1
rq==1.8.1

As far as I can see all usages of LooseVersion seem to be checking Django versions against 1.9 and 1.10. Since django-rq requires django>=2.0 all of them can probably be safely removed.