Closed nikhilweee closed 10 months ago
@selwin Would be nice to hear your thoughts and hopefully get this merged soon.
Hi @nikhilweee mind attaching a screenshot of before and after?
And how does this change affect Django < 4.2?
This is what /django_rq/queue/
looked like before
This is what /django_rq/queue/
looks like after this PR
The difference is subtle here, but is more pronounced in the next template
This is what /django-rq/queues/0/scheduled/
looked like before
This is what /django-rq/queues/0/scheduled/
looks like after this PR
EDIT: I was going crazy over the missing "Empty Queue" button, turns out it was removed in #608
@selwin My changes are based off of the current change_list.html
template.
I am not sure about the impact on Django < 4.2, but comparing v3.2.20 to v4.2.4 on GitHub, looks like that page hasn't changed. So I am tempted to say it's safe to assume that this PR should be applicable to both Django 3.2 and 4.2?
Do you mind testing this change on Django 3.2 at the very least? We don't have unit tests for this so I'd feel much more comfortable if I can see a screenshot of how it looks on older versions.
@selwin Here are results on Django 3.2
django_rq/queue
Before this PR
django_rq/queue
After this PR
django_rq/queues/0/scheduled
Before this PR
django_rq/queues/0/scheduled
After this PR
Hey @selwin, any thoughts?
Thanks!
This PR updates templates to better match with those of Django 4.2