search

rqlite / rqlite-java

Java client for rqlite, the lightweight distributed relational database
MIT License
30 stars 10 forks source link

Updated test table cleanup #7

Closed hprovenza closed 4 years ago

hprovenza commented 4 years ago

Is this better?

Also, I haven't done much contributing to public codebases in the past, so I'm not confident of etiquette, but I think I may be working with this project for a while. If it's better that I discuss proposed changes before submitting a PR, let me know!

I didn't use a @Before: creating the table is part of what is being tested, so it didn't seem quite appropriate.

otoolep commented 4 years ago

This looks good, thanks.

Unless you're proposing big changes, just creating a PR and having the discussion there is fine. But if you're about to create a large change, sometimes it's worth discussing first via an issue.