search

rqx110 / SnmpSharpNet

Simple Network Management Protocol (SNMP) .Net library written in C# (csharp). Implements protocol version 1, 2 and 3.
Other
80 stars 57 forks source link

SimpleSnmp suports SNMPV3 / add TCP connection / add SHA2 authentication SHA256, SHA384, SHA512 #12

Closed Christoph15072019 closed 2 years ago

Christoph15072019 commented 2 years ago

Hi,

I am working with SNMP and needed some more features in regards of SNMPV3. I have seen that there is a ticket already which requests the SHA2 authentication. I have implemented this and would like to contribute.

rqx110 commented 2 years ago

hi @Christoph15072019, I resarch about SNMP over TCP, it is not a common uage, and it is Experimental, see http://www.faqs.org/rfcs/rfc3430.html. so, we are currently not considering implementing this feature.

lextm commented 2 years ago

@rqx110 you should notice that even AES privacy is experimental but widely deployed. But anyway, as the repo owner you decide what should be included.

What I concern, however, is for the new code which added TCP support, how was it validated. Was it tested against another SNMP implementation such as NET-SNMP or not? The evidence is important to make sure the code does not only look good enough, but also works for real-world scenarios.

Christoph15072019 commented 2 years ago

Hi,

yes the code was validated against a device using NET-SNMP. I am using the library for a test program which verifies the functionality of a snmp device. There we had the requirement to communicate via TCP. So it was used already and it is working.

Greetings,

Christoph

Von: Lex Li @. Gesendet: Freitag, 30. September 2022 05:01 An: rqx110/SnmpSharpNet @.> Cc: ChristophW @.>; Mention @.> Betreff: Re: [rqx110/SnmpSharpNet] SimpleSnmp suports SNMPV3 / add TCP connection / add SHA2 authentication SHA256, SHA384, SHA512 (PR #12)

@rqx110 https://github.com/rqx110 you should notice that even AES privacy is experimental but widely deployed. But anyway, as the repo owner you decide what should be included.

What I concern, however, is for the new code which added TCP support, how was it validated. Was it tested against another SNMP implementation such as NET-SNMP or not? The evidence is important to make sure the code does not only look good enough, but also works for real-world scenarios.

— Reply to this email directly, view it on GitHub https://github.com/rqx110/SnmpSharpNet/pull/12#issuecomment-1263046823 , or unsubscribe https://github.com/notifications/unsubscribe-auth/AMTZ7PUG4YQUAS5VVM35WFDWAZJWBANCNFSM6AAAAAAQX5IZNM . You are receiving this because you were mentioned. https://github.com/notifications/beacon/AMTZ7PRXH5WN6G5YXNLKB7TWAZJWBA5CNFSM6AAAAAAQX5IZNOWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTSLJCIKO.gif Message ID: @. @.> >

rqx110 commented 2 years ago

separately to #13 and #14 SNMP over TCP is not not consider currently Thanks again @Christoph15072019