search

rr- / screeninfo

Fetch location and size of physical screens.
Other
208 stars 36 forks source link

`is_primary` boolean for Monitor objects #53

Closed cedric-uden closed 3 years ago

cedric-uden commented 3 years ago

Okay that went smoother as expected. I hope this fits. Thanks for any feedback. #52

rr- commented 3 years ago

Let's also make sure the formatting is OK

cedric-uden commented 3 years ago

oh thanks, I did overlook that.

rr- commented 3 years ago

One last thing – I think we also need to update the documentation in the README.

from screeninfo import get_monitors
for m in get_monitors():
    print(str(m))

README currently says that the code above will output:

>Monitor(x=1920, y=0, width=1920, height=1080, name=None)  
>Monitor(x=0, y=0, width=1920, height=1080, name=None)

but I think it will also now show , is_primary=False and , is_primary=True in addition. Please confirm and if that's the case please update that file also and we're good to go.

cedric-uden commented 3 years ago

Good catch. Should i also add the part width_mm=None, height_mm=None or should that be done in a separate commit?

rr- commented 3 years ago

Let's update it all at once, and I'll try to think of a way to make sure GitHub actions catch future documentation slip-ups

cedric-uden commented 3 years ago

Fantastic. Thanks for your support. This was a first for me. I will follow the updates here 😊

rr- commented 3 years ago

Thank you for the pull request and responding quickly 👍

cedric-uden commented 3 years ago

Right back at you. Also: will you update the version or should I have done that? Not sure about the procedure. And: not sure why (maybe it was a coincidence the last time?) but the Output in the README has the new line in the middle of the output.

rr- commented 3 years ago

@cedric-romain I've updated the README and added tests so that it won't be neglected again, should we add more properties to the Monitor class. I'll release a new version now.

rr- commented 3 years ago

Released as 0.7.

cedric-uden commented 3 years ago

Awesome. Thanks again. That was very insightful.