rr- / szurubooru

Image board engine, Danbooru-style.
GNU General Public License v3.0
715 stars 181 forks source link

Post Flow doesn't handle statistics well. #353

Open SleepingCrows opened 4 years ago

SleepingCrows commented 4 years ago

The feature implemented from Issue #351 can produce some visual errors for post statistics, overlayed on thumbnails that have a vertical aspect ratio, and more than two statistic types.

Screenshot_2020-10-01 Anthro cc BETA – Listing posts

Dreomite commented 4 years ago

Now I understand why there was min-width set.

I'm not quite sure how to deal with this, since I don't have project vision. I don't know what can be changed and what can't. And I would change quite a lot.

The problem with min-width is that it will either cut thumbnails too aggressively or, if proper post flow is implemented, there won't be more than 2 images per line on a typical mobile screen. You can browse DA on your phone to see what I'm talking about. Would it be inconvenient for a booru?

I played with CSS a bit and came up with this dirty solution which I don't particularly like. Just throwing ideas around.

Before: image

After: image

Firefox inspector CSS "diff":


/* app.min.css */

.post-list ul li .thumbnail-wrapper .stats, .post-list ul li .thumbnail-wrapper .type {
  /* padding: .33em .5em; */
  /* background: rgba(0,0,0,.5); */
  /* height: 1em; */
}

.post-list ul li .thumbnail-wrapper .stats .icon:not(:first-of-type) {
  /* margin-left: 1em; */
}

.post-list ul li .thumbnail-wrapper .stats {
  display: inline-flex;
  flex-wrap: wrap-reverse;
  justify-content: flex-end;
}

.post-list ul li .thumbnail-wrapper {
  /* line-height: 80%; */
}

/* Inline #5 */

.icon {
  background: rgba(0,0,0,.5);
  padding: .1em .5em;
  min-width: 2.1em;
}
SleepingCrows commented 4 years ago

Poking at it myself tonight, seeing what the possibilities are.

image

It may be simpler to make the stats stack up vertically all the time for visual consistency, given that the vertical height remains constant.

sgsunder commented 4 years ago

It may be simpler to make the stats stack up vertically all the time for visual consistency, given that the vertical height remains constant.

Hmm, would you be able to make a PR for that? CSS is not really my forte.

The CSS block for controlling post flow: https://github.com/rr-/szurubooru/blob/143f633eaac6b762bcae7877d98fec5e2f1a994c/client/css/post-list-view.styl#L137-L152

SleepingCrows commented 4 years ago

Hmm, would you be able to make a PR for that? CSS is not really my forte.

I'll see what i can do, but no gurantees right now. I'd have to go back and fokr a new repo, the repository I provide for anthro.cc 's modifications has a number of large changes that differ from the stock szurubooru frontend.