rr- / szurubooru

Image board engine, Danbooru-style.
GNU General Public License v3.0
704 stars 178 forks source link

Feature Request: Mass Safety/Tag edit on upload #382

Open HimegamiF opened 3 years ago

HimegamiF commented 3 years ago

I want to start by saying, this tool is awesome!

Like a lot of people I have my files somewhat sorted. So the process of individually selecting each post in the Mass Tag/Safety Edit feels like wasted energy when there are 20+ items being edited at a time. I see that this function can be achieved through the API. But I'd like to see something like this in the Upload GUI. image I understand this is basically only an issue when doing bulk uploads through the web. API might be the answer to all problems, but just because I can deploy a docker container doesn't mean I can figure out how to use the API.😅

neobooru commented 3 years ago

I can only unfortunately only answer one question, but you can search for untagged posts using tag-count:0

noirscape commented 3 years ago

Would like to see this too. I often tend to upload CG sets, which are most commonly distributed as ZIP files. Manually tagging these after upload, even with the mass tagger (which has its own problems) is a pain.

HimegamiF commented 3 years ago

I can only unfortunately only answer one question, but you can search for untagged posts using tag-count:0

Thanks! Apparently I'm blind and didn't look at the "Syntax Help" button...

neobooru commented 3 years ago

Another option would be to just enhance the already existing mass tagger. I personally use a custom application for my mass tagging needs which allows me to select multiple posts at once and add tags to them all in one click (aka not clicking the + button 100+ times). Same goes for the safety. Maybe a similar workflow could be implemented in the web app?

404Fox commented 3 years ago

This is probably what you guys are looking for https://github.com/rr-/szurubooru/commit/035ce19788626c007619c004ef3b702f70ac262e https://github.com/rr-/szurubooru/commit/902cca66f3062d6c8c93b4bb357d0522d7937d73 It'd be really cool if someone would merge that branch.

sgsunder commented 3 years ago

Is there a branch those commits are associated with? They seem to be dangling commits, which would make them hard to code review and merge...

404Fox commented 3 years ago

I mean just merge the fork whole or someone could copy/paste into a new commit here, preferably that person being the one who wrote it.

sgsunder commented 3 years ago

I mean just merge the fork whole or someone could copy/paste into a new commit here, preferably that person being the one who wrote it.

Yup, that's the issue. The fork seems to have been deleted/privated so I can't access any parent commits of it to merge it myself.

dkeatin2 commented 3 years ago

This would be a huge timesaver

noirscape commented 2 years ago

Is there a branch those commits are associated with? They seem to be dangling commits, which would make them hard to code review and merge...

They're a part of @Hunternif's szurubooru fork ( https://github.com/Hunternif/szurubooru , hunternif branch) who has asked on the discussions tab for some features to merge. I think it's safe to say this is a pretty desired feature, so I guess this is a formal request to Hunternif to see if they can cherry pick a PR together? Otherwise I could try making one...

Hunternif commented 2 years ago

@noirscape please go ahead and cherry-pick this commit. The first commit https://github.com/rr-/szurubooru/commit/035ce19788626c007619c004ef3b702f70ac262e should contain all the logic necessary for adding common tags on upload.

I tried to make my own PR just now (see branch https://github.com/Hunternif/szurubooru/tree/common-tags-on-upload), but unfortunately I haven't been able to test it. I've never quite learned to use docker properly, and it seems like every time I try to pull from Szuru master, something breaks my dev environment...