Audit outparam syscalls to ensure all use scratch

rr-debugger / rr

Record and Replay Framework

http://rr-project.org/

Other

9.08k stars 578 forks source link

Audit outparam syscalls to ensure all use scratch #889

Open joneschrisg opened 10 years ago

joneschrisg commented 10 years ago

I've fallen into the trap several times of thinking that only may-block syscalls need scratch, but in fact any syscall with outparams needs to use scratch. We should ensure that this is the case. On the fence about this for 1.0; lean towards no because we're not seeing problems in the field (or #876 might be this, but I doubt it).

joneschrisg commented 9 years ago

Good first bug for someone who's comfortable looking at the linux syscall ABI.