search

rr-wfm / MSBuild.Sdk.SqlProj

An MSBuild SDK that provides similar functionality to SQL Server Data Tools (.sqlproj) projects
MIT License
380 stars 42 forks source link

Attempt to fix issue with extra command line arguments #501

Closed ErikEJ closed 4 months ago

ErikEJ commented 5 months ago

fixes #500

jmezach commented 5 months ago

Can we test that this actually fixes something?

ErikEJ commented 5 months ago

If we build a preview package that the OP can consume in his pipeline?

jmezach commented 5 months ago

Sure. I can upload the preview package to NuGet.org tomorrow.

jmezach commented 5 months ago

Turned out to be really busy last Friday so I didn't get around to it. But I've uploaded a pre-release version of this PR to NuGet.org which should be available soon. Version 2.7.0-beta.30.g42c33ba1c7.

ErikEJ commented 5 months ago

@popcatalin81 Are you able to test this preview package in your pipeline?

https://www.nuget.org/packages/MSBuild.Sdk.SqlProj/2.7.0-beta.30.gf2c33ba1c7

ErikEJ commented 5 months ago

@popcatalin81 Ping?

popcatalin81 commented 5 months ago

@popcatalin81 Ping?

Yes, I will test right away. I was ooo for the past week.

popcatalin81 commented 4 months ago

@ErikEJ This took longer than I wanted it too due to some big changes to the project pipeline that made the whole CI be offline for the past weeks.

However I can confirm now the fix worked.