rra / podlators

Format POD source into various output formats
https://www.eyrie.org/~eagle/software/podlators/
Other
6 stars 11 forks source link

Unconditionally style contents of `L<>` tags #21

Closed mjsir911 closed 1 year ago

mjsir911 commented 1 year ago

This lets users properly highlight man(1) references even if guesswork doesn't report it as a manref. The offending links looked something like this:

@@RXVT_NAME@@perl(3)

Being able to wrap these in L<> to bold the entire string is a nicety.

A (too) thorough writeup, exploration, & justification of this PR can be found here

TODO:

rra commented 1 year ago

Thank you for the analysis and the initial patch! I have a committed a fix for this that will be in the next release.

The problem was a bit more complex than your patch, because by the time cmd_l gets the text, it has already been formatted, including man page references. To ensure the formatting is correct, cmd_l needs to use the underlying link attributes and reproduce the formatting. Otherwise, it risks double-formatting the reference in some edge cases or, more likely, missing some formatting. I think I found a way to do this that should work reliably, and added a test for it.

mjsir911 commented 1 year ago

Thank you @rra!