search

rragan / try-require

try/require mechanism to conditionally load a module using require.
10 stars 4 forks source link

fixed the whitespace #5

Closed hildoer closed 9 years ago

hildoer commented 9 years ago

Thanks again for the quick response. One more favor, can you also do an NPM publish on the 1.2.0+ version?

rragan commented 9 years ago

It is published

From: Anthony Hildoer notifications@github.com<mailto:notifications@github.com> Reply-To: rragan/try-require reply@reply.github.com<mailto:reply@reply.github.com> Date: Thursday, May 21, 2015 at 10:20 AM To: rragan/try-require try-require@noreply.github.com<mailto:try-require@noreply.github.com> Subject: [try-require] fixed the whitespace (#5)

Thanks again for the quick response. One more favor, can you also do an NPM publish on the 1.2.0+ version?

You can view, comment on, or merge this pull request online at:

https://github.com/rragan/try-require/pull/5

Commit Summary

File Changes

Patch Links:

— Reply to this email directly or view it on GitHubhttps://github.com/rragan/try-require/pull/5.

hildoer commented 9 years ago

Thank you Richard.

This is the 1.2.0 version that you NPM published?

Anthony Hildoer Principal Engineer BlueRival Software

text | anthony@bluerival.com office | 1.800.665.2029 mobile | 720.689.2001 skype | ahildoer icq | 423790250

On May 21, 2015, at 11:37 AM, Richard Ragan notifications@github.com wrote:

It is published

From: Anthony Hildoer notifications@github.com<mailto:notifications@github.com> Reply-To: rragan/try-require reply@reply.github.com<mailto:reply@reply.github.com> Date: Thursday, May 21, 2015 at 10:20 AM To: rragan/try-require try-require@noreply.github.com<mailto:try-require@noreply.github.com> Subject: [try-require] fixed the whitespace (#5)

Thanks again for the quick response. One more favor, can you also do an NPM publish on the 1.2.0+ version?

You can view, comment on, or merge this pull request online at:

https://github.com/rragan/try-require/pull/5

Commit Summary

  • Merge commit '2128b179b39b3a4679a87b10f829d0b36af02498'
  • fix formatting, swap tab characters for four spaces each

File Changes

  • M README.mdhttps://github.com/rragan/try-require/pull/5/files#diff-0 (7)
  • M index.jshttps://github.com/rragan/try-require/pull/5/files#diff-1 (44)
  • M package.jsonhttps://github.com/rragan/try-require/pull/5/files#diff-2 (8)
  • M test/all.test.jshttps://github.com/rragan/try-require/pull/5/files#diff-3 (56)

Patch Links:

— Reply to this email directly or view it on GitHubhttps://github.com/rragan/try-require/pull/5. — Reply to this email directly or view it on GitHub https://github.com/rragan/try-require/pull/5#issuecomment-104367237.

rragan commented 9 years ago

Yes 1.2.0

From: Anthony Hildoer [mailto:notifications@github.com] Sent: Thursday, May 21, 2015 10:43 AM To: rragan/try-require Cc: Ragan, Richard Subject: Re: [try-require] fixed the whitespace (#5)

Thank you Richard.

This is the 1.2.0 version that you NPM published?

Anthony Hildoer Principal Engineer BlueRival Software

text | anthony@bluerival.commailto:anthony@bluerival.com office | 1.800.665.2029 mobile | 720.689.2001 skype | ahildoer icq | 423790250

On May 21, 2015, at 11:37 AM, Richard Ragan notifications@github.com<mailto:notifications@github.com> wrote:

It is published

From: Anthony Hildoer notifications@github.com<mailto:notifications@github.com<mailto:notifications@github.com%3cmailto:notifications@github.com>> Reply-To: rragan/try-require reply@reply.github.com<mailto:reply@reply.github.com<mailto:reply@reply.github.com%3cmailto:reply@reply.github.com>> Date: Thursday, May 21, 2015 at 10:20 AM To: rragan/try-require try-require@noreply.github.com<mailto:try-require@noreply.github.com<mailto:try-require@noreply.github.com%3cmailto:try-require@noreply.github.com>> Subject: [try-require] fixed the whitespace (#5)

Thanks again for the quick response. One more favor, can you also do an NPM publish on the 1.2.0+ version?

You can view, comment on, or merge this pull request online at:

https://github.com/rragan/try-require/pull/5

Commit Summary

  • Merge commit '2128b179b39b3a4679a87b10f829d0b36af02498'
  • fix formatting, swap tab characters for four spaces each

File Changes

  • M README.mdhttps://github.com/rragan/try-require/pull/5/files#diff-0 (7)
  • M index.jshttps://github.com/rragan/try-require/pull/5/files#diff-1 (44)
  • M package.jsonhttps://github.com/rragan/try-require/pull/5/files#diff-2 (8)
  • M test/all.test.jshttps://github.com/rragan/try-require/pull/5/files#diff-3 (56)

Patch Links:

— Reply to this email directly or view it on GitHubhttps://github.com/rragan/try-require/pull/5. — Reply to this email directly or view it on GitHub https://github.com/rragan/try-require/pull/5#issuecomment-104367237.

— Reply to this email directly or view it on GitHubhttps://github.com/rragan/try-require/pull/5#issuecomment-104368683.

hildoer commented 9 years ago

Sorry, to bother you again. npmjs.com (https://www.npmjs.com/package/try-require) doesn't seem to see your publish of 1.2.0. Also, npm installs on CLI also only see 1.1.0. Can you try to push again? Maybe bump the version again and include the whitespace changes.

rragan commented 9 years ago

OK, published again as 1.2.1 with whitespace changes.

more .npmrc email=rragan@gmail.com registry = http://www.npmjs.org username=rrragan LM-SJN-00872172:~ rragan$ cd try-require LM-SJN-00872172:try-require rragan$ npm publish

I'm not seeing it show up yet. I guess it may be an npm delay in updating things. Odd though

hildoer commented 9 years ago

yeah, it must be an npm issue. thank you so much for helping on this. i will keep tracking it with npm support directly.

rragan commented 9 years ago

I will try one more publish from home this evening. Shouldn’t matter but you never know. I double checked that I was not publishing to our internal npm repo (and I was not).

Rich

From: Anthony Hildoer [mailto:notifications@github.com] Sent: Thursday, May 21, 2015 1:30 PM To: rragan/try-require Cc: Ragan, Richard Subject: Re: [try-require] fixed the whitespace (#5)

yeah, it must be an npm issue. thank you so much for helping on this. i will keep tracking it with npm support directly.

— Reply to this email directly or view it on GitHubhttps://github.com/rragan/try-require/pull/5#issuecomment-104412346.

hildoer commented 9 years ago

Richard, looks like npmjs finally updated. Don't know if you continued to try anything, but its up finally. Thank you!

rragan commented 9 years ago

Nothing special. It was just weird but cleared up.