rrazgriz / RATS

Harmony-based Unity Editor QOL
https://vpm.razgriz.one
MIT License
83 stars 7 forks source link

add Harmony as a VPM dependency #15

Closed konsti219 closed 1 year ago

konsti219 commented 1 year ago

When a user adds this package they no longer have to manually add Harmony.

I have a simple example with this here: https://konsti219.github.io/TestPackage-vpm/

rrazgriz commented 1 year ago

Thanks for noting this; not having it as a dependency is an intentional choice. I thought long and hard about this when finalizing the release structure, and considered both options. There's a couple of problems with adding it as a dependency:

Ultimately, this led me to not include Harmony by default. This isn't ideal, but it's the best compromise for compatibility, in my opinion.

My ideal case would be for VRChat to include Harmony in the com.vrchat.base SDK package, so that RATS can be satisfied by a dependency to that (with a manual release without the dep for non-VRC use cases).

konsti219 commented 1 year ago

Thanks for explanation

rrazgriz commented 1 year ago

RATS 1.1.4 now depends on com.vrchat.base ^3.4.0, which bundles Harmony, and marks one.razgriz.harmony-vpm as a legacy package, which will cause VCC to remove it (in VCC 2.1.4 and up).

This automates handling of the Harmony dependency for VCC projects.