rrbrambley / MessageBeast-Android

A library for building Message-based apps on App.net
MIT License
5 stars 0 forks source link

Using MinMaxPair.minId to load messages from DB is wrong #1

Closed rrbrambley closed 10 years ago

rrbrambley commented 10 years ago

Currently, when loading messages from the sqlite db, the min Id of the currently loaded messages are used to determine the "before date" – the date that must come after the display date of all messages to be loaded.

However, when the displayDate != createdAt on a message (e.g. an ohai date is used), the min id may correspond to a message with a display date that is after a message with a greater id. I think.

Perhaps the solution is to always keep the min display date in memory and query that way?

rrbrambley commented 10 years ago

fixed in a62cf67371223e42c08e249839a86a3049dd5d49