search

rrbrambley / MessageBeast-Android

A library for building Message-based apps on App.net
MIT License
5 stars 0 forks source link

MessageManager's sendPendingDeletions() (and thus sendAllUnsent()) offers no feedback/callback #9

Closed rrbrambley closed 10 years ago

rrbrambley commented 10 years ago

When calling sendPendingDeletions(), we should send a broadcast or execute a callback after the operation is complete.

sendUnsentMessages() uses broadcasts, but sendPendingDeletions may be better suited for a handler since there are no long-running operations (e.g. file upload)

After the sendPendingDeletions() fix is added, it should be incorporated into sendAllUnsent()

rrbrambley commented 10 years ago

fixed as of commit 23c8761562844036a40d5cec2a128bdbe4845729