search

rrbutani / xterm-js-sys

Rust bindings for Xterm.js
https://rrbutani.github.io/xterm-js-sys/examples
MIT License
32 stars 2 forks source link

Documentation on string enums doesn't stick around #1

Open rrbutani opened 4 years ago

rrbutani commented 4 years ago

Since we're using #![deny(missing_docs)] this makes the build fail.

rrbutani commented 4 years ago

Some of the lints we're using also get mad at the code wasm-bindgen generates; specifically missing_docs and unsafe_code.

rrbutani commented 4 years ago

Fixed in rustwasm/wasm-bindgen#2141.

Right now we use the fork of wasm-bindgen that's in the PR but once it gets merge we should switch back to upstream. Until that happens, I'm leaving this issue open.