rrcampbell-exe / ryan-r-campbell

The website, blog, and portfolio for Ryan R. Campbell.
https://www.ryanrcampbell.com
1 stars 0 forks source link

Refactor CSS #29

Open rrcampbell-exe opened 5 months ago

rrcampbell-exe commented 5 months ago

Looks for opportunities to refactor the CSS. Consider utility classes as a starting point for things like box-shadow and other repeated styles throughout the codebase. This should also focus on ensuring that light-theme/dark-theme implementation is as streamlined as possible.

rrcampbell-exe commented 4 months ago

Once these refactors are complete, the app should be reorganized into simply "components" and "pages." It shouldn't rely on the "experiences" structure.

rrcampbell-exe commented 4 months ago

Opportunities for global refactors:

rrcampbell-exe commented 4 months ago

You cannot use custom properties with var inside of media queries.

Others will be implemented.

rrcampbell-exe commented 4 months ago

This issue is going to be treated as an epic in order to break it up a bit. The following files (taken in order from imported-styles.css) still need to be refactored, however.

@import './experiences/author/pages/Landing/AuthorLanding.scss';
@import './experiences/shared/components/Reviews/Reviews.scss';
@import './experiences/author/pages/Books/BooksLanding.scss';
@import './experiences/tech/pages/Landing/TechLanding.scss';
@import './experiences/author/pages/Podcast/Podcast.scss';
@import './experiences/shared/components/HamburgerMenu/HamburgerMenu.scss';
@import './experiences/shared/components/NotFound/NotFound.scss';
@import './experiences/shared/components/NotificationBanner/NotificationBanner.scss';
@import './experiences/shared/components/Loading/Loading.scss';
@import './experiences/shared/pages/About/GeneralAbout.scss';
@import './experiences/shared/components/Quote/Quote.scss';
@import './experiences/shared/components/TextAndImage/TextAndImage.scss';
@import './experiences/shared/components/Blog/BlogTags.scss';

In the meantime, the work that has been done on the other eight Sass files plus App.css will be merged.