search

rrd108 / vue-mess-detector

A static code analysis tool for detecting code smells and best practice violations in Vue.js and Nuxt.js projects
MIT License
226 stars 9 forks source link

add rule (vue-reccomended): Empty lines in component/instance options #40

Open rrd108 opened 5 months ago

rrd108 commented 5 months ago

https://vuejs.org/style-guide/rules-recommended.html#empty-lines-in-component-instance-options

David-Pena commented 3 months ago

When a component would be considered "crowded"? 🤔

rrd108 commented 3 months ago

What about if the line length exceed 125 characters?

David-Pena commented 3 months ago

125 chars sounds fine as the limit to consider it crowded

rrd108 commented 3 months ago

Ok great.

I changed analyzer.ts a little bit, so do not forget to update yours before sending a PR

David-Pena commented 3 months ago

I just scrolled to the whole list of changes, great work!

rrd108 commented 3 months ago

I just scrolled to the whole list of changes, great work!

I hope I did not ruined your current work with it. I finished something much earlier I planned, so I used my extra time on this.

David-Pena commented 3 months ago

I hope I did not ruined your current work with it. I finished something much earlier I planned, so I used my extra time on this.

Not at all, after my last two PRs I have been a bit busy. But soon I'll get back to help decreasing that issues count haha