Closed bbqbaron closed 7 years ago
Ok, so first off this is seriously amazing work 🎉 This is honestly fantastic!
The PR looks great overall! The only problem is having src/retyped
take a dependency of jsoo. Right now it's compiled as a library dependency of the two modules insrc
, meaning it can target native OCaml if you run jbuilder build src/cli.exe
- hopefully we don't have to lose that.
Can we take a dependency on another OCaml regex library? Native target is really helpful for development speed.
You can test out the native target with jbuilder build src/cli.exe
and then run ./_build/default/src/cli.exe -debug <my-file.js>
This is perfect! Thanks for implementing this so quickly 😄 Do you think this is all good to merge?
I'd say so; native and JS tests seem to work (where "native test" is just building cli.exe
and running it on my test file).
From #15. This handles modules-within-modules according to the following logic. Certainly open to feedback, since I haven't written enough flow decls to know all the permutations!
/
foo/bar/baz
becomes a moduleBarBaz
in thefoo.re
output. I could also recursively nest them by ensuring aBar
and adding theBaz
decls inside it; not sure if this is a use case that happens a lot. I wanted to get an impression/opinion before adding what seems like a polish feature.@@bs.module "foo/bar/whatever"
inside each external inFoo.Bar
.Some changes are formatting; will annotate the one real change.