rrdelaney / ReasonablyTyped

:diamond_shape_with_a_dot_inside: Converts Flow and TypeScript definitions to Reason interfaces
https://rrdelaney.github.io/ReasonablyTyped/
MIT License
518 stars 24 forks source link

Update Test Expectations? #36

Closed bbqbaron closed 7 years ago

bbqbaron commented 7 years ago

I think this commit introduced a number of compiler test failures. Not sure of background, but I thought I'd at least register it. Since the commit message was Stop union types in parameters from generating precode, perhaps the fixtures are just out of date?

E.g. duplicate-type-params seems to have dropped:

type union_of_number_or_string =
  | Number float
  | String string;

type number_or_string;

external number_or_string : union_of_number_or_string => number_or_string =
  "Array.prototype.shift.call" [@@bs.val];
rrdelaney commented 7 years ago

I broke the test case a little while ago 😅 I was in the middle of a feature I was finishing up and thought I'd push soon, then other things came up - I'll fix them tonight

rrdelaney commented 7 years ago

Tests should be all fixed 😄