Make ReasonablyTyped build with bsb-native

rrdelaney / ReasonablyTyped

:diamond_shape_with_a_dot_inside: Converts Flow and TypeScript definitions to Reason interfaces

https://rrdelaney.github.io/ReasonablyTyped/

MIT License

518 stars 24 forks source link

Make ReasonablyTyped build with bsb-native #38

Closed bsansouci closed 7 years ago

bsansouci commented 7 years ago

This PR makes the project build with bsb-native. There are two things to lookout for here: 1) We need to figure out how publishing to opam will work. There is opam_of_packagejson that can generate the appropriate things but bsb-native would need to be on opam probably. 2) This uses a slightly older version of flow (v0.42.0 specifically) because bsb-native only support ocaml 4.02.3.

Build times:

js: 2.3s
bytecode: 2.5s
native: 4.3s

rrdelaney commented 7 years ago

Don't worry about the failing tests for now, the CI is broken 😅

Sorry I haven't gotten around to checking this out, I'll definitely merge it before the week is over though!

bsansouci commented 7 years ago

No worries! I haven't found time to fix the CI. It should invoke bsb and all (I know that flow works because we're using it for rewitness).