search

rrdelaney / reason-scripts

:beginner: Create a ReasonML and React development environment
MIT License
628 stars 58 forks source link

Turn on .bs.js suffix + in-source generation #36

Closed chenglou closed 6 years ago

chenglou commented 6 years ago

Yo @rrdelaney! Can we turn on https://bucklescript.github.io/docs/en/build-configuration.html#package-specs and https://bucklescript.github.io/docs/en/build-configuration.html#suffix? It's the new default

rrdelaney commented 6 years ago

Sounds good to me 😁 I can probably do that this weekend

baransu commented 6 years ago

I would like to help with this. I'm using 1.0.0-alpha2 and at startup there is missing index.bs.js error. I see that package spec was updated but I cannot find BuckleScript build step. How do you recommend to implement this?

rrdelaney commented 6 years ago

@Baransu I've been super-busy lately, and haven't had a lot of time to work on this unfortunately. The -alpha releases will most likely all be broken. If you want to help out, working on reason-webpack-plugin would be a huge help! Right now it doesn't detect changes to .re files, so adding context dependencies to the webpack plugin would be awesome :smile:

rrdelaney commented 6 years ago

Done as part of v0.9.0